Skip to content

Improve error message for too long file in ext/tidy #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 8, 2024

As suggested in #14862 (comment)

@nielsdos nielsdos requested a review from Girgias July 8, 2024 11:50
@nielsdos
Copy link
Member Author

nielsdos commented Jul 8, 2024

Not sure about long/large though.

@devnexen
Copy link
Member

devnexen commented Jul 8, 2024

well just my opinion, but that fits with ENAMETOOLONG. I know not related :)

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, it is already an improvement. :)

@nielsdos nielsdos merged commit c695b1d into php:master Jul 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants